First round of node-module updates #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 17, 2023 17:39
TODO: Fix the warnings and reset to error at some point
pmeijer
commented
Aug 21, 2023
| @@ -36,16 +36,11 @@ describe('ServerWorkerManager - SimpleWorkers', function () { | |||
| projectId: projectId, | |||
| commitHash: ir.commitHash | |||
| }, function (err, result) { | |||
| try { | |||
| expect(err).to.equal(null); | |||
There was a problem hiding this comment.
For whatever reason, in node 18 the wrapped error message within the Assertion error got truncated. So the error message checks in the tests didn't match anymore
kecso
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jwt bumped from v8 to v9 and to avoid breaking changes for users with RSA keys < 2046 bits the check is by default turned off (
config.authentication.jwt.allowInsecureKeySizes = true). Instead a warning is logged when this setting is true.jsdoc templates had security issues w/o any clear update or replacement - so instead the default (non-dark) theme is used for source code documentation.
This change does not handle all the security issues reported - but since all tests are passing this is a good milestone.